fix: Check for balancer in peer_cluster role property

src/managers/config.py

@@ -21,6 +21,7 @@
 from core.workload import CharmedKafkaPaths, WorkloadBase
 from literals import (
     ADMIN_USER,
+    BALANCER,
     BALANCER_GOALS_TESTING,
     BROKER,
     DEFAULT_BALANCER_GOALS,
@@ -604,9 +605,7 @@ def server_properties(self) -> list[str]:
         if self.state.cluster.tls_enabled and self.state.unit_broker.certificate:
             properties += self.tls_properties + self.zookeeper_tls_properties
 
-        # FIXME: change peer_cluster_relation to peer_cluster_orchestrator_relations after the center-of-star
-        #  change is effective
-        if self.state.runs_balancer or self.state.peer_cluster_relation:
+        if self.state.runs_balancer or BALANCER.value in self.state.peer_cluster.roles:
             properties += KAFKA_CRUISE_CONTROL_OPTIONS.splitlines()
             properties += self.metrics_reporter_properties
 

tests/unit/test_config.py

@@ -25,7 +25,7 @@
     JVM_MEM_MIN_GB,
     OAUTH_REL_NAME,
     PEER,
-    PEER_CLUSTER_RELATION,
+    PEER_CLUSTER_ORCHESTRATOR_RELATION,
     REL_NAME,
     SUBSTRATE,
     ZK,
@@ -583,9 +583,12 @@ def test_cruise_control_reporter_only_with_balancer(harness: Harness[KafkaCharm]
     # Default roles value does not include balancer
     assert reporters_config_value not in harness.charm.broker.config_manager.server_properties
 
-    # FIXME: change peer_cluster_relation to peer_cluster_orchestrator_relations after the center-of-star
-    #  change is effective
     with harness.hooks_disabled():
-        harness.add_relation(PEER_CLUSTER_RELATION, "balancer")
+        peer_cluster_relation_id = harness.add_relation(
+            PEER_CLUSTER_ORCHESTRATOR_RELATION, CHARM_KEY
+        )
+        harness.update_relation_data(
+            peer_cluster_relation_id, harness.charm.app.name, {"roles": "broker,balancer"}
+        )
 
     assert reporters_config_value in harness.charm.broker.config_manager.server_properties