Update the snap version of via upstream .go-version #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiseschmidtgen
approved these changes
Oct 23, 2024
| def update_go_version(dry_run: bool): | ||
| k8s_version = (COMPONENTS / "kubernetes/version").read_text().strip() | ||
| url = f"https://raw.githubusercontent.com/kubernetes/kubernetes/refs/tags/{k8s_version}/.go-version" | ||
| with urllib.request.urlopen(url) as response: |
There was a problem hiding this comment.
We could additionally check for a failure of the request here.
There was a problem hiding this comment.
urlopen will raise an exception if it doesn't get a happy code (like a 2xx)
HomayoonAlimohammadi
approved these changes
Oct 24, 2024
| @@ -134,6 +140,25 @@ def update_component_versions(dry_run: bool): | |||
| pull_helm_chart() | |||
|
|
|||
|
|
|||
| def update_go_version(dry_run: bool): | |||
There was a problem hiding this comment.
Do we need to include any sort of testing for this? Or maybe I'm just being paranoid :D
There was a problem hiding this comment.
so, what do you have in mind @HomayoonAlimohammadi ? As far as i see it -- none of this update-component-versions code is tested (nor is it in the product -- its just build script stuff)
I guess we can start testing it (linting/formatting...etc). Maybe need a card and another task for it? I don't see it being critical b/c it doesn't impact the final product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The update-components job should check if the go version necessary to build the upstream k8s needs to be updated.
Details
Fetch the upstream .go-version when updating the components for a branch
Update the snapcraft.yaml to reflect any go version changes.