Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to integration tests LXD container removal #757

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Oct 22, 2024

Sometimes the removing an LXD container is stuck forever. Adding a timeout prevents the CI from hanging indefinitely in this case.
It is very likely that this happens because of how we configure the LXD profile. Since this will undergo significant changes in the future, I did not dig too deeply into this issue.
https://discourse.ubuntu.com/t/lxd-containers-not-removed-in-ci-even-with-force-flag/49039

@bschimke95 bschimke95 requested a review from a team as a code owner October 22, 2024 10:29
@bschimke95 bschimke95 marked this pull request as draft October 22, 2024 10:29
@bschimke95 bschimke95 changed the title add debug level logging for lxd Add timeout to integration tests LXD container removal Oct 23, 2024
@bschimke95 bschimke95 marked this pull request as ready for review October 23, 2024 08:27
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a TODO here with a note to make a proper fix.
IMHO, we should rather work on a fix before we keep this timeout in forever.
If we add a timeout I would much rather put a timeout on the entire test to avoid it getting stuck for 6 hours.

@bschimke95
Copy link
Contributor Author

Several reasons why I put the timeout here instead of on the test level:

  1. This is a infra-specific bug. It would be unnecessary to limit this for non-LXD runs.
  2. We don't want the CI to fail because of this issue. AFAIK setting a timeout on the test level would fail the suite.

"IMHO, we should rather work on a fix before we keep this timeout in forever."
That's not so straight forward. As discussed, a proper fix requires some investigation which takes time (we have a card for that). This workaround unblocks us and TBH I don't see any issue that we could realistically face with that.

That being said, I added a comment/TODO.

Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bschimke95! LGTM.

@bschimke95 bschimke95 merged commit abb6f7f into main Oct 24, 2024
19 of 20 checks passed
@bschimke95 bschimke95 deleted the KU-1917/lxd-removal-issue branch October 24, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants