add jwt to dial jump server #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
reviewed
Jan 24, 2025
kian99
approved these changes
Jan 28, 2025
| connInfo, err := s.sshManager.ConnInfoFromModelUUID(ctx, s.allowedModelUUID, s.userWithAccess) | ||
| c.Assert(err, qt.IsNil) | ||
| c.Assert(connInfo.Addrs, qt.HasLen, 1) | ||
| c.Assert(connInfo.JWT, qt.Not(qt.HasLen), 0) |
There was a problem hiding this comment.
Not a requirement, but we could also test that the JWT has the expected claims.
alesstimec
reviewed
Jan 29, 2025
SimoneDutto
force-pushed
the
JUJU-7351/add-jwt-auth
branch
2 times, most recently
from
5a52ecc to
8b7e4d6
Compare
SimoneDutto
force-pushed
the
JUJU-7351/add-jwt-auth
branch
from
8b7e4d6 to
e596269
Compare
alesstimec
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add the jwt when dial controller's ssh server.
The JWT is created together when resolving the controller's addresses.
Engineering checklist
Test instructions