-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new design and add user flows as dummy pages WD-8469 #216
Use new design and add user flows as dummy pages WD-8469 #216
Conversation
edlerd
commented
Jan 26, 2024
- adjusted to new design
- added dummy pages for register, reset, device and setup
a803eb2
to
95e5f77
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 76.55% 75.60% -0.95%
==========================================
Files 9 11 +2
Lines 627 537 -90
==========================================
- Hits 480 406 -74
+ Misses 134 116 -18
- Partials 13 15 +2 ☔ View full report in Codecov by Sentry. |
ecc0dee
to
f8f98c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is quite a lot of code in just one commit, any chance to split it into smaller ones?
It's not that many code changes, most of the lines are due to dependency updates in package-lock.json, which are a prerequisite for other changes. So factoring them out into individual PRs is painful, because they would rely on each other. Edit: I changed the structure of the PR, keeping the changes, but breaking them into a bit smaller commits. |
…o bundle css) Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
f8f98c1
to
6e1b5fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the comment I made on the login page. One thing I don't understand is what the plan is for these registration pages, the fields are going to come from Kratos and I would expect that we are going to ask for more attributes rather than just username and password. We can iterate on this further when we do the work on the backend so I have no problem with merging this once the issue on the login page is fixed.
Here are some screen shots on what the new pages look like:
Login Page:
@edlerd looks good to me afaict, what is the policy for frontend tests?how do we catch broken UI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor thing and I think we can merge it
Signed-off-by: David Edler <[email protected]>
c4e1ff8
to
88bb621
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good. MFA options obviously missing but I assume this is out of scope at this stage |