Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config options to use dashes rather than underscores for consistency with framework-added options #71

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

mthaddon
Copy link
Contributor

Applicable spec: N/A

Overview

Rename config options to use dashes rather than underscores for consistency with framework-added options.

Rationale

Consistency with other config options.

Module Changes

N/A

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@mthaddon mthaddon requested a review from a team as a code owner September 16, 2024 13:14
arturo-seijas
arturo-seijas previously approved these changes Sep 16, 2024
arturo-seijas
arturo-seijas previously approved these changes Sep 16, 2024
arturo-seijas
arturo-seijas previously approved these changes Sep 16, 2024
Copy link

Test coverage for e1645f7

Name                                                              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py                                 0      0      0      0   100%
httprequest_lego_provider/apps.py                                     4      0      0      0   100%
httprequest_lego_provider/dns.py                                     68      0      8      0   100%
httprequest_lego_provider/forms.py                                   21      0      2      0   100%
httprequest_lego_provider/management/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/management/commands/__init__.py             0      0      0      0   100%
httprequest_lego_provider/management/commands/allow_domains.py       21      0      2      0   100%
httprequest_lego_provider/management/commands/create_user.py         14      0      0      0   100%
httprequest_lego_provider/management/commands/list_domains.py        22      0      8      0   100%
httprequest_lego_provider/management/commands/revoke_domains.py      21      0      2      0   100%
httprequest_lego_provider/migrations/0001_initial.py                  8      0      0      0   100%
httprequest_lego_provider/migrations/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/models.py                                   9      0      0      0   100%
httprequest_lego_provider/serializers.py                             24      0      0      0   100%
httprequest_lego_provider/urls.py                                     8      0      0      0   100%
httprequest_lego_provider/views.py                                   74      0     16      0   100%
-------------------------------------------------------------------------------------------------------------
TOTAL                                                               294      0     38      0   100%

Static code analysis report

Run started:2024-09-16 15:46:02.557166

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1715
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@mthaddon mthaddon merged commit b588e44 into main Sep 17, 2024
17 checks passed
@mthaddon mthaddon deleted the config-dashes branch September 17, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants