Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filename from label to structured_metadata #180

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Conversation

Abuelodelanada
Copy link
Contributor

Issue

In order to avoid high cardinality in Loki this PR moves the filename label from regular labels to structured_metadata

This PR goes in tandem with canonical/loki-k8s-operator#445

Testing Instructions

Run tests

@sed-i
Copy link
Contributor

sed-i commented Sep 9, 2024

Add tandem PR for the k8s charm?

@Abuelodelanada
Copy link
Contributor Author

Add tandem PR for the k8s charm?

Lib updated with new promtail version and pipeline_stages
canonical/loki-k8s-operator#455

@Abuelodelanada Abuelodelanada merged commit 8085448 into main Sep 13, 2024
13 checks passed
@Abuelodelanada Abuelodelanada deleted the filename_label branch September 13, 2024 19:18
@Abuelodelanada Abuelodelanada restored the filename_label branch September 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants