[experimental] UV support for Python plugins #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lengau
commented
Aug 21, 2024
lengau
commented
- Have you signed the CLA?
lengau
force-pushed
the
experimental/uv
branch
2 times, most recently
from
3138ed5 to
4e6a806
Compare
cmatsuoka
reviewed
Aug 22, 2024
| self, *, properties: PluginProperties, part_info: infos.PartInfo | ||
| ) -> None: | ||
| super().__init__(properties=properties, part_info=part_info) | ||
| use_uv_attr_name = f"{properties.plugin}_use_uv" |
There was a problem hiding this comment.
Having a parameter like <plugin>-package-manager: uv (defaulting to pip) could allow us to use other package managers in the future (and avoid using a boolean property). There's also the option to have use-uv in build-attributes but that would not tie to Python-based plugins specifically.
| def _get_find_python_interpreter_commands(self) -> list[str]: | ||
| """Get the commands that find a staged Python interpreter. |
There was a problem hiding this comment.
Maybe we could have these large helper scripts available as a separate utility to be invoked at build time?
There was a problem hiding this comment.
This has been done separately.
lengau
force-pushed
the
experimental/uv
branch
from
4e6a806 to
e716f68
Compare
Closed
|
Closing this as this implementation isn't really usable with the current state of the code, but I think this is feasible in the future with @cmatsuoka's suggestions: #936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.