Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of small integrations fixes #1603

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

Lukewh
Copy link
Contributor

@Lukewh Lukewh commented Jun 8, 2023

Done

  • Fixed badly worded error
  • Fixed incorrect rendering of channel

How to QA

Issue / Card

Fixes #1598
Fixes https://warthogs.atlassian.net/browse/WD-4449

Screenshots

image

image

@webteam-app
Copy link

Demo starting at https://charmhub-io-1603.demos.haus

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1603 (d3a04ae) into main (f682882) will decrease coverage by 0.47%.
The diff coverage is 4.00%.

❗ Current head d3a04ae differs from pull request most recent head aa6dd95. Consider uploading reports for the commit aa6dd95 to get more accurate results

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
- Coverage   34.52%   34.06%   -0.47%     
==========================================
  Files          16       16              
  Lines        1393     1415      +22     
==========================================
+ Hits          481      482       +1     
- Misses        912      933      +21     
Flag Coverage Δ
python 34.06% <4.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
webapp/interfaces/views.py 28.16% <ø> (ø)
webapp/interfaces/logic.py 17.09% <4.00%> (-1.62%) ⬇️

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lukewh Lukewh merged commit d8d90e1 into canonical:main Jun 8, 2023
@Lukewh Lukewh deleted the integrations-fixes branch June 9, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charmhub Integrations tab minor issues: wrong help/channel and missing charms
3 participants