Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release badge #25

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Updated release badge #25

merged 3 commits into from
Mar 6, 2024

Conversation

a-velasco
Copy link
Contributor

Issue

Worfklow badge was broken

Solution

Updated workflow link

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but IMHO shortcut the length of badge.

README.md Outdated
@@ -1,5 +1,5 @@
# Charmed PostgreSQL ROCK
[![Publish ROCK](https://github.com/canonical/charmed-postgresql-rock/actions/workflows/publish.yaml/badge.svg)](https://github.com/canonical/charmed-postgresql-rock/actions/workflows/publish.yaml)
[![Release to GitHub Container Registry](https://github.com/canonical/charmed-postgresql-rock/actions/workflows/release.yaml/badge.svg)](https://github.com/canonical/charmed-postgresql-rock/actions/workflows/release.yaml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, you can shortcut Release to GitHub Container Registry to Release to GHCR, GHCR Release or Release to GHCR.io. It will be too long badge on https://releases.juju.is/?team=Data

@a-velasco a-velasco merged commit 968ea94 into 14-22.04 Mar 6, 2024
5 checks passed
@a-velasco a-velasco deleted the update-badge branch March 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants