Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-1086] Add dependencies for postgis and pltcl plugins #21

Merged
merged 10 commits into from
Jan 29, 2024

Conversation

TakoB222
Copy link
Contributor

@TakoB222 TakoB222 commented Jan 19, 2024

Added symlinks for postgis plugins:

  • address_standardizer
  • address_standardizer_data_us
  • postgis_raster
  • postgis_tiger_geocoder
  • postgis_topology
  • postgis

Added environment variables required by postgis_raster and pltcl:

  • LD_LIBRARY_PATH
  • TCL_LIBRARY

rockcraft.yaml Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Henrique Neppel <[email protected]>
rockcraft.yaml Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Henrique Neppel <[email protected]>
rockcraft.yaml Outdated Show resolved Hide resolved
@TakoB222 TakoB222 changed the title Add postgis extension symlinks [DPE-1086] Add postgis extension symlinks Jan 21, 2024
@TakoB222 TakoB222 changed the title [DPE-1086] Add postgis extension symlinks [DPE-1086] Add dependencies for postgis and pltcl plugins Jan 22, 2024
@TakoB222 TakoB222 changed the title [DPE-1086] Add dependencies for postgis and pltcl plugins [DPE-1086] Add dependencies for postgis and pltcl plugins Jan 22, 2024
@TakoB222 TakoB222 changed the title [DPE-1086] Add dependencies for postgis and pltcl plugins [DPE-1086] Add dependencies for postgis and pltcl plugins Jan 22, 2024
@marceloneppel
Copy link
Member

The paths you added seem to be unavailable in the rock @TakoB222. Can you please check that?

rockcraft.yaml Outdated Show resolved Hide resolved
TakoB222 and others added 2 commits January 22, 2024 14:00
Co-authored-by: Mykola Marzhan <[email protected]>
@taurus-forever
Copy link
Contributor

The paths you added seem to be unavailable in the rock @TakoB222. Can you please check that?

@TakoB222 please check this... it is still topical:

:: ~/prime
:: + export LD_LIBRARY_PATH=/snap/rockcraft/1494/none:/root/prime/usr/lib/ x86_64-linux-gnu/blas:/root/prime/usr/lib/ x86_64-linux-gnu/lapack
:: + LD_LIBRARY_PATH=/snap/rockcraft/1494/none:/root/prime/usr/lib/
:: /bin/bash: line 87: export: `x[86](https://github.com/canonical/charmed-postgresql-rock/actions/runs/7613923309/job/20735539637#step:5:87)_64-linux-gnu/blas:/root/prime/usr/lib/': not a valid identifier
:: /bin/bash: line [87](https://github.com/canonical/charmed-postgresql-rock/actions/runs/7613923309/job/20735539637#step:5:88): export: `x86_64-linux-gnu/lapack': not a valid identifier
'override-prime' in part 'non-root-user' failed with code 1.
Recommended resolution: Review the scriptlet and make sure it's correct.

rockcraft.yaml Outdated Show resolved Hide resolved
@taurus-forever
Copy link
Contributor

@dragomirp @marceloneppel please review to merge this for mid-sprint delivery.

Co-authored-by: Alex Lutay <[email protected]>
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TakoB222! Have you tested if the changes here allow the creation of the postgis extensions?

I tested it in the charm, and it seems not to work.

Also, I believe both LD_LIBRARY_PATH, TCL_LIBRARY should be part of the environment variables of the pebble service from the charm rather than being set here.

@TakoB222
Copy link
Contributor Author

Hi @TakoB222! Have you tested if the changes here allow the creation of the postgis extensions?

I tested it in the charm, and it seems not to work.

Also, I believe both LD_LIBRARY_PATH, TCL_LIBRARY should be part of the environment variables of the pebble service from the charm rather than being set here.

Okay, will check

rockcraft.yaml Outdated Show resolved Hide resolved
@dragomirp
Copy link
Contributor

Build the rock locally for testing with the suggested changes (overlay-packages, remove exports) and the plugin tests of the charm seemed to work fine. Uploaded the image at ghcr.io/dragomirp/renovate-charm@sha256:91080a24ddc9e377427ecba15a4da1f6127bf38f0163fd6bc72730fab6127abb

Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @TakoB222 and @dragomirp!

@marceloneppel marceloneppel merged commit 6248f55 into canonical:14-22.04 Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants