-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-1086] Add dependencies for postgis and pltcl plugins #21
Conversation
Co-authored-by: Marcelo Henrique Neppel <[email protected]>
Co-authored-by: Marcelo Henrique Neppel <[email protected]>
postgis
extension symlinkspostgis
extension symlinks
postgis
extension symlinkspostgis
and pltcl
plugins
postgis
and pltcl
plugins
The paths you added seem to be unavailable in the rock @TakoB222. Can you please check that? |
Co-authored-by: Mykola Marzhan <[email protected]>
@TakoB222 please check this... it is still topical:
|
@dragomirp @marceloneppel please review to merge this for mid-sprint delivery. |
Co-authored-by: Alex Lutay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TakoB222! Have you tested if the changes here allow the creation of the postgis extensions?
I tested it in the charm, and it seems not to work.
Also, I believe both LD_LIBRARY_PATH
, TCL_LIBRARY
should be part of the environment variables of the pebble service from the charm rather than being set here.
Okay, will check |
Build the rock locally for testing with the suggested changes (overlay-packages, remove exports) and the plugin tests of the charm seemed to work fine. Uploaded the image at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @TakoB222 and @dragomirp!
Added symlinks for postgis plugins:
Added environment variables required by
postgis_raster
andpltcl
: