Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wrong filter in mobile 'Find a Partner' section #1081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AslanGM
Copy link
Contributor

@AslanGM AslanGM commented Oct 19, 2023

Done

  • Replaced the duplicate inclusion of '_programme-filters.html' with '_services-filters.html' in the mobile filters section of the 'Find a Partner' page to align with the desktop version.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8002/
  • Run through the following QA steps

Issue / Card

None

Screenshots

Screenshots from the canonical website.
On desktop:
Find a Canonical partner | Partners 2023-10-19 15-39-34

On mobile:
Find a Canonical partner | Partners 2023-10-19 15-39-56

Screenshot from my localhost after fix:
Find a Canonical partner | Partners 2023-10-19 15-41-10

[if relevant, include a screenshot]

@webteam-app
Copy link

AslanGM is not a collaborator of the repo

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1081 (ae6021b) into main (067b015) will increase coverage by 0.56%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

❗ Current head ae6021b differs from pull request most recent head 389320c. Consider uploading reports for the commit 389320c to get more accurate results

@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
+ Coverage   65.87%   66.44%   +0.56%     
==========================================
  Files          10       10              
  Lines         885      885              
==========================================
+ Hits          583      588       +5     
+ Misses        302      297       -5     
Flag Coverage Δ
python 66.44% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants