Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: point all CKF charms to 1.8/beta channel to match release #730

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Oct 11, 2023

Point all CKF charms to their corresponding 1.8/beta channel. This PR should be merged once the charms are available in the correct track.

@DnPlas DnPlas requested a review from a team as a code owner October 11, 2023 07:01
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all charms use channel: 1.8/*, we need to include the track names for each charm

@ca-scribner
Copy link
Contributor

We can probably use this pr as a template for an easy fix here

@DnPlas
Copy link
Contributor Author

DnPlas commented Nov 20, 2023

@ca-scribner ready for a second pass, I must've just done a quick search and replace w/o noticing the versions. Please let me know what you think.

Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm, but with a few comments

@DnPlas
Copy link
Contributor Author

DnPlas commented Nov 21, 2023

Thanks @ca-scribner for the review. I have updated based on your comments, let me know what you think.

@kimwnasptd kimwnasptd merged commit 4875513 into main Nov 22, 2023
@kimwnasptd kimwnasptd deleted the KF-4493-fix-channels branch November 22, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants