Add Airbyte rock #18
Merged
Add Airbyte rock #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelkawi-a
force-pushed
the
airbyte-rock
branch
29 times, most recently
from
96c0b50 to
b5f852d
Compare
kelkawi-a
force-pushed
the
airbyte-rock
branch
from
482fd17 to
1632f92
Compare
linostar
suggested changes
Oct 14, 2024
kelkawi-a
force-pushed
the
airbyte-rock
branch
4 times, most recently
from
ad2fec8 to
b0daddc
Compare
kelkawi-a
force-pushed
the
airbyte-rock
branch
from
b0daddc to
6fe7361
Compare
AmberCharitos
approved these changes
Oct 17, 2024
| mkdir -p ${CRAFT_PART_INSTALL}/usr/local/lib/python3.10/dist-packages | ||
| cp -r $(which kubectl) ${CRAFT_PART_INSTALL}/usr/local/bin/kubectl | ||
|
|
||
| pip install --upgrade setuptools pip airbyte-cdk==5.12.0 \ |
There was a problem hiding this comment.
If you end up having more of these in future you can add a requirements.txt file. Not necessary now.
| - airbyte-connector-builder-server | ||
|
|
||
| local-files: | ||
| after: [organize-tars] |
There was a problem hiding this comment.
Does this really need to go after organize-tars?
| curl -fsSL https://pkgs.k8s.io/core:/stable:/v1.31/deb/Release.key | gpg --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg | ||
| chmod 644 /etc/apt/keyrings/kubernetes-apt-keyring.gpg # allow unprivileged APT programs to read this keyring | ||
| apt-get update | ||
| apt-get install -y kubectl |
There was a problem hiding this comment.
Can this not be a build-package?
There was a problem hiding this comment.
It actually needs to be included in the final build as the application itself uses kubectl. Including it as a stage-snap did not work for some reason, so I opted to install it manually.
onurmus
approved these changes
Oct 17, 2024
| # stdlib CVEs | ||
| CVE-2024-24790 | ||
| CVE-2023-24538 | ||
| CVE-2023-24540 |
There was a problem hiding this comment.
If they are not present anymore, we can remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds the Airbyte app from source using Rockcraft, and builds the Airbyte charm with it. A few things to note:
v0.63.8fromv0.60.0due to a version mismatch with the destination connector introduced in the integration test. Versions pastv0.63.8introduce breaking changes to the charm and the overall structure of Airbyte. A future update will look into updating to the latestv1.xversion.kubectlas part ofstage-snapsdid not seem to include it in the final build, hence why I manually install it usingoverride-build.