Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use ConfigParser and not SafeConfigParser #405

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

jirihnidek
Copy link
Collaborator

@jirihnidek jirihnidek commented Jan 18, 2024

  • Card ID: CCT-263
  • The SafeConfigParser was deprecated in Python 3.2. This class was renamed to ConfigParser
  • Fixed some unit tests

* Card ID: CCT-263
* The SafeConfigParser was deprecated in Python 3.2. This class
  was renamed to ConfigParser
* ssl.wrap_socket() was marked as deprecated in Python 3.7
  * It stopped to work in Python 3.12
* We use it only for unit tests
* Such tests should not be part of unit tests, because these
  tests looks like more like integration tests
Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky m-horky merged commit 89db8ff into main Jan 22, 2024
8 checks passed
@m-horky m-horky deleted the jhnidek/fix_configparser_issue branch January 22, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants