-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sheet2linkml so that it can be run from the root directory of this package #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few fairly trivial comments on this PR. Feel free to address them in this PR or separate ones, but for the most part this PR is good to go.🚀
Do the rest of you get something like this when you authenticate for the Google Sheets API (in Chrome?)
I figure we should either eliminate this warning or at least warn "other users" that they may see soemthing liek this and explain why. |
What did we decide to do about warnings like
|
I'm tempted to suggest modifying the README to include an estimate of how long to takes to generate the model form the Google Sheet, although there's nothing analogous for the other steps in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modified code for generating the model from the Google Sheet looks good and runs in my environment.
I left some comments but wasn't in review mode at the time.
- I marked @sujaypatil96's comment about using the
vendor
directory as complete. - I agree with his suggestion for a short
-o
parameter for specifying the model generation's output file, but that seems minor. - I defer to @sujaypatil96's judgement about logging practices.
- I think the main README is good but the Google Sheet model generation README could use some clarification or updating. I'll take a stab at that now. That could include a warning that web browsers may consider the process of authenticating the Google Sheets API unsafe, if other people are getting messages like the one I pasted above.
- I get a lot of warnings during the model generation. I think @gaurav and I have spoken about that before and that it might require making a request of the people who maintain the Google Sheet.
Most of the duplicate permissible value warnings should go away once the CCDH Terminology Service stops giving us duplicate PVs (cancerDHC/ccdh-terminology-service#27), and then anything that remains will be an error in the Google Sheet. I think this warning is fine for now. |
I don't see this. On the "OAuth consent screen" tab on your GCI APIs and Services page, could you please make sure that your app has a publishing status of "Testing" and that your e-mail address has been added to the list of Test Users? I think that's the way to suppress this warning. |
Thanks. I think I've tried various OAuth consent configurations over the weeks. My latest workflow can be found in #98 I'll try these suggestions, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this PR @gaurav. I think it's ready to be merged.🚀
This PR updates sheet2linkml so that it can be run from the root directory of this package. To do this:
regen-google-sheets
(now renamed togenerate-model
) now includes the Google Sheet ID and no longer changes directory when running.gh-deploy
target in the Makefile so we can once again publish these changes to GitHub Pages using mike.generators/google-sheets/sheet2linkml
tovendors/sheet2linkml/sheet2linkml
.Along with these changes, I've also generated the model and all of its artifacts.
Closes #95, closes #84.