Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate sheet2linkml into its own repository #100

Open
1 task done
gaurav opened this issue Sep 9, 2021 · 3 comments
Open
1 task done

Separate sheet2linkml into its own repository #100

gaurav opened this issue Sep 9, 2021 · 3 comments
Assignees

Comments

@gaurav
Copy link
Collaborator

gaurav commented Sep 9, 2021

This program does something quite different from rest of this repository, so we should probably move it elsewhere. We can then publish it to PyPI and import it for use by this repository, and maintain separate tests in the other repository (#12).

Also:

  • When creating its setup.py file, note that it requires a minimum of Python 3.9 since it uses generic types.

(see #8 and #95 for previous discussions of this issue)

@sujaypatil96
Copy link
Contributor

sujaypatil96 commented Sep 30, 2021

Linking this to the sheet2linkml package on Github and sheet2linkml project on PyPI.

I think this issue is ready to be closed.

@gaurav
Copy link
Collaborator Author

gaurav commented Oct 1, 2021

Let's close it after we remove sheet2linkml from this repo? I think we still need to figure out how and where to call sheet2linkml in order to generate a new CRDC-H in LinkML model (#16) -- I'm not sure if those GitHub Actions should be here or in the sheet2linkml repo?

@sujaypatil96
Copy link
Contributor

I think we should be good to close this issue once PR #128 has been merged.

@sujaypatil96 sujaypatil96 self-assigned this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants