feat(SIP section menu): Update SIP section menu #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add keyboard accessibility Update hover state for active menu element Add ARIA roles
|
@Borges-Porteous Still a few things missing to make it fully accessible:
|
added 2 commits
March 29, 2020 14:56
feat(SIP section menu): Update sip-section-menu.cs
delisma
commented
Mar 29, 2020
delisma
force-pushed
the
master
branch
8 times, most recently
from
16a78da to
3fa6591
Compare
delisma
force-pushed
the
master
branch
2 times, most recently
from
552c89a to
1ec6588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add keyboard accessibility
Update hover state for active menu element
Add ARIA roles