Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textract): implement textract connector #2928

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat(textract): implement textract connector #2928

merged 1 commit into from
Aug 23, 2024

Conversation

igpetrov
Copy link
Contributor

@igpetrov igpetrov commented Jul 23, 2024 •
edited by DenovVasil
Loading

Implement textract connector

Related

Next step, implement e2e tests for this connector :

Add documentation

@igpetrov igpetrov self-assigned this Jul 23, 2024
@igpetrov igpetrov linked an issue Jul 23, 2024 that may be closed by this pull request
[AWS Textract] Implement Connector #2923
Closed
@igpetrov igpetrov force-pushed the 2923-aws-textract-implement-connector branch 3 times, most recently from 96b93de to d16e7c9 Compare July 28, 2024 18:43
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DenovVasil DenovVasil force-pushed the 2923-aws-textract-implement-connector branch from 1b76283 to 269e54c Compare August 13, 2024 20:12
@Oleksiivanov Oleksiivanov self-requested a review August 15, 2024 10:17
@DenovVasil DenovVasil force-pushed the 2923-aws-textract-implement-connector branch 3 times, most recently from fa4b8f6 to b0c8cf6 Compare August 20, 2024 08:05
Oleksiivanov
Oleksiivanov requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Oleksiivanov Oleksiivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great job and great start! I’ve added some comments. Also, please add a link to the ticket in the PR. I don’t see any e2e tests here, so please create a ticket for that and link it as a follow-up task. It can be implemented later , as next step I think

igpetrov
igpetrov commented Aug 23, 2024
View reviewed changes
.../aws/aws-textract/src/main/java/io/camunda/connector/textract/TextractConnectorFunction.java
@ElementTemplate.PropertyGroup(id = "input", label = "Configure input")
},
documentationRef =
"https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/amazon-textract/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to add documentation after the connector is completed. Ping me or @Oleksiivanov for more details.

@igpetrov
Copy link
Contributor Author

Looks great, thank you!

I left few minor comments in code. As next steps, consider the following:

  • Move PR to Ready for review
  • Double check the CodeQL security check that there is no leak of PII or critical information, or maybe reduce amout of information that is logged.
  • Sign the SLA: feat(textract): implement textract connector #2928 (comment)
  • Let the Connectors team that they need to take a review before you merge

Unfortunately, I cannot approve the PR because GitHub thinks that I am an author. @Oleksiivanov do you see any issues with this PR?

@igpetrov
Copy link
Contributor Author

yeah, almost forgot, please squash your commits into single commit

@DenovVasil DenovVasil force-pushed the 2923-aws-textract-implement-connector branch from 6269e28 to 4d95a3e Compare August 23, 2024 11:03
@igpetrov
Copy link
Contributor Author

BTW, which account are you using, it it @DenovVasil or @denovVasyl? I think, only one is authorized with Camunda.

@DenovVasil DenovVasil force-pushed the 2923-aws-textract-implement-connector branch 4 times, most recently from 4cf39be to b31a962 Compare August 23, 2024 12:54
@DenovVasil
Copy link
Contributor

DenovVasil

I use this one (https://github.com/DenovVasil)

@Oleksiivanov Oleksiivanov marked this pull request as ready for review August 23, 2024 12:58
@Oleksiivanov Oleksiivanov requested a review from a team as a code owner August 23, 2024 12:58
@johnBgood
Copy link
Collaborator

Maybe it's done already but remember to add the docs + the templates in the web-modeler repo :) Thanks!

@DenovVasil DenovVasil force-pushed the 2923-aws-textract-implement-connector branch from b31a962 to c838bb7 Compare August 23, 2024 13:44
@DenovVasil
Copy link
Contributor

sure #3162

@Oleksiivanov Oleksiivanov added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit b2b98a8 Aug 23, 2024
10 checks passed
@Oleksiivanov Oleksiivanov deleted the 2923-aws-textract-implement-connector branch August 23, 2024 14:13
mathias-vandaele pushed a commit that referenced this pull request Aug 26, 2024
@igpetrov @DenovVasil @mathias-vandaele
feat(textract): introduce Amazon textract connector (#2928)
9c41e89 
Co-authored-by: DenovVasil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oleksiivanov Oleksiivanov Oleksiivanov approved these changes

@johnBgood johnBgood johnBgood approved these changes

@DenovVasil DenovVasil Awaiting requested review from DenovVasil

Assignees

@DenovVasil DenovVasil

@igpetrov igpetrov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS Textract] Implement Connector
5 participants
@igpetrov @CLAassistant @DenovVasil @johnBgood @Oleksiivanov