Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gomplate now upgrades with the v #2777

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: gomplate now upgrades with the v #2777

merged 1 commit into from
Jan 17, 2025

Conversation

jessesimpson36
Copy link
Contributor

@jessesimpson36 jessesimpson36 commented Jan 16, 2025

Which problem does the PR fix?

Our renovate configuration had a problem which was causing it to not process any packageRules for gomplate, because the packageName is actually hairyhenderson/gomplate and not just gomplate. Furthermore, the v has to be inside the named regex named "currentVersion" for it to be recognized as necessary for the new version.

Here's my evidence of it working:
jessesimpson36/renovate-gomplate-test#3

2025-01-16-184955_grim

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@jessesimpson36 jessesimpson36 self-assigned this Jan 16, 2025
@jessesimpson36 jessesimpson36 requested a review from a team January 16, 2025 23:56
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@jessesimpson36 jessesimpson36 merged commit 1f0b22b into main Jan 17, 2025
11 checks passed
@jessesimpson36 jessesimpson36 deleted the gomplate-v branch January 17, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants