Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: adding chart verifier validation #2034

Merged
merged 5 commits into from
Aug 1, 2024
Merged

ci: adding chart verifier validation #2034

merged 5 commits into from
Aug 1, 2024

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

issue: #366
Creating a workflow to run the chart verifier.

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hamza-m-masood
Copy link
Contributor Author

Sample run: https://github.com/camunda/camunda-platform-helm/actions/runs/9607140588/job/26497802993
There are many failing checks. Other issues need to be created to fix the failing checks. For now I have created a dispatch trigger and an input to provide the helm deployment folder. It defaults to latest.

@hamza-m-masood hamza-m-masood marked this pull request as ready for review June 21, 2024 02:08
@hamza-m-masood hamza-m-masood self-assigned this Jun 21, 2024
@hamza-m-masood hamza-m-masood added this to the 8.6 Release Cycle milestone Jun 21, 2024
@hamza-m-masood hamza-m-masood requested a review from a team June 21, 2024 02:09
@hamza-m-masood hamza-m-masood changed the title ci: adding chart verifier worfklow ci: adding openshift chart verifier worfklow Jun 21, 2024
@hamza-m-masood hamza-m-masood changed the title ci: adding openshift chart verifier worfklow ci: adding OpenShift chart verifier worfklow Jun 21, 2024
@hamza-m-masood hamza-m-masood linked an issue Jun 21, 2024 that may be closed by this pull request
[TASK] Investigate chart-verifier tool benefits #366
Closed
@aabouzaid aabouzaid force-pushed the main branch 2 times, most recently from 0c8b1ea to 7dcc6f7 Compare July 13, 2024 22:37
@aabouzaid aabouzaid force-pushed the main branch 18 times, most recently from b3fe6b5 to 9b91e96 Compare July 25, 2024 07:59
aabouzaid
aabouzaid requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to main.

@hamza-m-masood hamza-m-masood mentioned this pull request Aug 1, 2024
Closed
@hamza-m-masood hamza-m-masood reopened this Aug 1, 2024
aabouzaid
aabouzaid approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@aabouzaid aabouzaid changed the title ci: adding OpenShift chart verifier worfklow ci: adding chart chart verifier worfklow Aug 1, 2024
@aabouzaid aabouzaid changed the title ci: adding chart chart verifier worfklow ci: adding chart verifier worfklow Aug 1, 2024
@aabouzaid aabouzaid changed the title ci: adding chart verifier worfklow ci: adding chart verifier validation Aug 1, 2024
@hamza-m-masood hamza-m-masood merged commit b3c67e4 into main Aug 1, 2024
6 checks passed
@hamza-m-masood hamza-m-masood deleted the chart-verifier branch August 1, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@hamza-m-masood hamza-m-masood

Labels
area/ci
Projects
None yet
Milestone
8.6 Release Cycle
Development

Successfully merging this pull request may close these issues.

[TASK] Investigate chart-verifier tool benefits
2 participants
@hamza-m-masood @aabouzaid