Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: configure zeebe-gateway context path #1672

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

romansmirnov
Copy link
Member

Which problem does the PR fix?

Following up with camunda/camunda#17467, Zeebe was migrated to Spring Webmvc. That way, the property to configure the context path in the Gateway changes. Therefore, this PR set the server.servlet.context-path property to set the context path.

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@houssain-barouni houssain-barouni added the version/8.6 Camunda applications/cycle version label Jun 19, 2024
@aabouzaid aabouzaid force-pushed the rs-zeebe-servlet-context-path branch from 8af67e8 to d75dca7 Compare June 19, 2024 19:59
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@aabouzaid aabouzaid changed the title chore: use to configure context path refactor: configure zeebe-gateway context path Jun 20, 2024
@aabouzaid aabouzaid merged commit 9868f00 into main Jun 20, 2024
10 checks passed
@aabouzaid aabouzaid deleted the rs-zeebe-servlet-context-path branch June 20, 2024 09:50
aabouzaid pushed a commit that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor version/8.6 Camunda applications/cycle version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants