Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added GH app token in add-to-project workflow #1153

Merged
merged 3 commits into from
Dec 20, 2023
Merged

chore: added GH app token in add-to-project workflow #1153

merged 3 commits into from
Dec 20, 2023

Conversation

drodriguez-305
Copy link
Contributor

Which problem does the PR fix?

https://github.com/camunda/distribution/issues/161

What's in this PR?

replace PAT tokens with GH app tokens generated in GHA.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@drodriguez-305 drodriguez-305 added area/ci kind/task size/xs Relative effort/time: Extra Small area/security Marks an issue as improving security of the project labels Dec 13, 2023
@drodriguez-305 drodriguez-305 self-assigned this Dec 13, 2023
@aabouzaid aabouzaid changed the title added GH app token in add-to-project workflow chore: added GH app token in add-to-project workflow Dec 18, 2023
aabouzaid
aabouzaid approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@aabouzaid aabouzaid merged commit 9aecd6b into main Dec 20, 2023
5 checks passed
@aabouzaid aabouzaid deleted the 161-task-use-gh-app-token-instead-of-pat-in-the-workflows-1 branch December 20, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesimpson36 jessesimpson36 jessesimpson36 approved these changes

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@drodriguez-305 drodriguez-305

Labels
area/ci area/security Marks an issue as improving security of the project kind/task size/xs Relative effort/time: Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drodriguez-305 @aabouzaid @jessesimpson36