-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: removing dev comments before the release #1127
Conversation
@drodriguez-305 I like the script 😁 However, I believe it could be much simpler since we have everything in the repo. First of all, we only need to remove the development comments, not all comments. So, the goal here is to simplify the script by fixing the root cause in the repo itself. |
This reverts commit c1ecb91.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, thanks a lot 🚀
Which problem does the PR fix?
This PR will remove development notes in our values and manifest files. It was requested by support as some customers have been confused by these.
#1089
What's in this PR?
Created a script that will run in our release process that will remove all
TODO
andNOTES
sections. The script will ignore any files that are located in the "./test" directory. It will also create a change log and upload as artifact for reference.The script will be called from our chart-release.yaml before the actual release steps.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
After opening the PR: