Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release info #4780

Merged
merged 3 commits into from
Jan 8, 2025
Merged

chore: update release info #4780

merged 3 commits into from
Jan 8, 2025

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Jan 8, 2025

Proposed Changes

This PR updates the release info for v5.31.0 according to the suggestions (1, 2). I've also removed the placeholder-like part about bug fixes as it was anyway hidden below the fold, so a user would have to scroll to see it.

image

image

Related to #4753

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 8, 2025
@barmac barmac force-pushed the release-info-5-31-u branch from 93b9c18 to 11f6f6c Compare January 8, 2025 09:49
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rework the run-time versions part as discussed here to make it more actionable for end users. CC @jarekdanielak to contribute link to documentation.

Consider to also link form changes from documentation, if documentation exists.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jan 8, 2025
Co-authored-by: Jarek Danielak <[email protected]>
@barmac
Copy link
Collaborator Author

barmac commented Jan 8, 2025

Consider to also link form changes from documentation, if documentation exists.

I will add a link but it will be dead until camunda/camunda-docs#4773 is released.

@nikku
Copy link
Member

nikku commented Jan 8, 2025

I will add a link but it will be dead until camunda/camunda-docs#4773 is released.

Fine by me.

@barmac barmac force-pushed the release-info-5-31-u branch from 42ae026 to d574141 Compare January 8, 2025 13:19
@barmac
Copy link
Collaborator Author

barmac commented Jan 8, 2025

OK I've added the links with the query params to track source. The screenshots in the top comment are up to date.

@barmac
Copy link
Collaborator Author

barmac commented Jan 8, 2025

I'm merging this and building the release, so that we can unfreeze main.

@barmac barmac merged commit cf78ddc into main Jan 8, 2025
8 of 10 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Jan 8, 2025
@barmac barmac deleted the release-info-5-31-u branch January 8, 2025 16:27
@github-actions github-actions bot added this to the M84 milestone Jan 8, 2025
@nikku
Copy link
Member

nikku commented Jan 8, 2025

Thanks, really nice follow-up improvements 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants