Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use vault for windows certificates #4257

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

chore: use vault for windows certificates #4257

wants to merge 4 commits into from
+42 −3

Conversation

marstamm
Copy link
Member

@marstamm marstamm commented Apr 22, 2024 •
edited
Loading

related to #4243

@marstamm marstamm self-assigned this Apr 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Apr 22, 2024
barmac
barmac reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this.

.github/workflows/BUILD_ON_DEMAND.yml Outdated Show resolved Hide resolved
.github/workflows/BUILD_ON_DEMAND.yml Outdated Show resolved Hide resolved
.github/workflows/BUILD_ON_DEMAND.yml Show resolved Hide resolved
@barmac
Copy link
Collaborator

barmac commented Apr 23, 2024

Based on https://www.electron.build/code-signing#windows, I pushed 22a12d0

@barmac barmac force-pushed the use-vault-for-certs branch 2 times, most recently from 91e0e5c to 73bc611 Compare April 23, 2024 07:49
@nikku nikku added the backlog Queued in backlog label Apr 26, 2024 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Apr 26, 2024
@nikku nikku added this to the M76 milestone Apr 26, 2024
@nikku nikku added the ready Ready to be worked on label Apr 26, 2024 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Apr 26, 2024
@nikku nikku removed this from the M76 milestone May 7, 2024
@nikku
Copy link
Member

nikku commented May 7, 2024

Postponed, removed from M76 milestone.

@nikku nikku added the backlog Queued in backlog label Jun 18, 2024 — with bpmn-io-tasks
@nikku nikku removed the ready Ready to be worked on label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac left review comments

Assignees

@marstamm marstamm

Labels
backlog Queued in backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marstamm @barmac @nikku