-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(self-managed): update OpenShift routes instructions #3997
Merged
Merged
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6c710f6
changes for routes
hamza-m-masood cf9835b
fix indentation
conceptualshark 29864a0
fixed link
hamza-m-masood 625e71f
added github issue link
hamza-m-masood 1798e4e
fix spelling error
hamza-m-masood abff907
reword
hamza-m-masood 878d697
reword
hamza-m-masood a968bac
pkcs
hamza-m-masood d81b1b6
cert to certificate
hamza-m-masood 8139970
ingress
hamza-m-masood 7a2d969
jks
hamza-m-masood d8ee383
adding space in pkcs
hamza-m-masood 436fa1d
change ns
hamza-m-masood 87d1ee8
reworded comments
hamza-m-masood 2cd6048
changed placeholders to default names
hamza-m-masood 012ea64
added changes to 8.6
hamza-m-masood 6746f11
added full stops
hamza-m-masood 68ffca6
added in space at start of comments
hamza-m-masood bbf451a
style(formatting): minor grammatical tweaks
christinaausley 79e7bb0
add space after the commit hash
aabouzaid 8d27b9c
adding back spaces to comments
hamza-m-masood 8dbc2c2
formatting and copyedits
conceptualshark d4e905c
Merge branch 'main' into routes-modification
conceptualshark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we're consistent with ingress/Ingress casing across our docs. @conceptualshark WDYT? Do you think this warrants an issue for the backlog? Would you like to take a look at this across the SM docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I can spin something off to go through this. I think the capitalization does a lot of work here.