4214 restarted process instance

[punitdarira]

Related to #4214

[mboskamp]

Hey @punitdarira, thanks for contributing! Feel free to mark this PR as "Ready for review" when you are done with it and want someone from the team to review the changes. 👍

[psavidis]

Hey @punitdarira,
How is the progress going with this Pull Request? Are you still interested to work on it? If not, no worries, you can always open a new one in the future.

[punitdarira]

Hey @punitdarira, How is the progress going with this Pull Request? Are you still interested to work on it? If not, no worries, you can always open a new one in the future.

Hi @mboskamp, @psavidis,
This PR is slightly dependent on #4334 for tests
I though of creating common tests for this and above mentioned PR.
I tested this feature locally and it was working as expected.
Currently I am working on the dependent ticket.

[punitdarira]

• Need to add the add column sql in db/upgrade. I wasn't sure how the naming of the file works.

[punitdarira]

Hi! @mboskamp @psavidis,
This PR is ready to review. I updated existing test cases itself.

[psavidis]

Hi! @mboskamp @psavidis, This PR is ready to review. I updated existing test cases itself.

Hello @punitdarira. I'd like to review your PR. In the meantime, would you like to fix those conflicts?

To increase the visibility here, please see below:

A. CockroachDB will be discontinued with 7.22 release and onwards.

Conflict Root-cause: The files activiti.cockroachdb.create.history.sql, activiti.cockroachdb.drop.history.sql do not exist anymore on master
Solution: Drop them in your fork and omit the addition of the column for CockroachDB
References: Remove CockroachDB Ticket

[psavidis]

Hello @punitdarira,

I went through the PR and tested your changes.
Could you consider deleting the files for CockRoachDB? (see my comment)

Then i can proceed with testing it against our CI.

[punitdarira]

Hello @punitdarira,

I went through the PR and tested your changes. Could you consider deleting the files for CockRoachDB? (see my comment)

Then i can proceed with testing it against our CI.

Hi @psavidis,
The conflicts have been resolved.

[psavidis]

Hello @punitdarira,
I went through the PR and tested your changes. Could you consider deleting the files for CockRoachDB? (see my comment)
Then i can proceed with testing it against our CI.

Hi @psavidis, The conflicts have been resolved.

Hi @punitdarira ,

I've used a draft PR to execute the code against the CI.
The db migration suite is failing.

Could you please add the new column and index to the migration scripts? You can see this commit which fixes the problem.

PS: You can use the following maven command to test your changes by running the db migration test suite:

mvn verify -Pinstance-migration,database,h2 -f qa/test-db-instance-migration/pom.xml

[psavidis]

Hello @punitdarira,
I went through the PR and tested your changes. Could you consider deleting the files for CockRoachDB? (see my comment)
Then i can proceed with testing it against our CI.

Hi @psavidis, The conflicts have been resolved.

Hi @punitdarira ,

I've used a draft PR to execute the code against the CI. The db migration suite is failing.

Could you please add the new column and index to the migration scripts? You can see this commit which fixes the problem.

PS: You can use the following maven command to test your changes by running the db migration test suite:

mvn verify -Pinstance-migration,database,h2 -f qa/test-db-instance-migration/pom.xml

Hello @punitdarira ,

We are interested to include this work in the upcoming 7.22 release.
Therefore, if you have time to make the contribution yourself today that would be perfect.

If not, that's not an issue, i will cherry pick it tomorrow from the draft PR that triggered the CI and proceed with merging your fork.

Thanks,
Petros

[punitdarira]

@psavidis ,
Sorry for the delay. I've pushed the changes

[psavidis]

Thank you @punitdarira,

I've added tests and currently waiting for the CI results.

When done, i'll replicate the commit to your fork and then i'll proceed with the merging.

Best,
Petros