Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone ngeo UI sbr #1477

Open
wants to merge 2 commits into
base: prod-2-9
Choose a base branch
from
Open

Standalone ngeo UI sbr #1477

wants to merge 2 commits into from

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner force-pushed the standalone-ngeo-ui-sbr branch 3 times, most recently from 4ca7716 to a65e18d Compare October 11, 2024 08:43
ui/src/vite-env.d.ts Outdated Show resolved Hide resolved
@sbrunner sbrunner force-pushed the standalone-ngeo-ui-sbr branch 9 times, most recently from f6a4c89 to 027cab6 Compare October 16, 2024 13:10
@sbrunner sbrunner marked this pull request as ready for review October 16, 2024 15:40
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the same extension for README.rst and ui/README.md ?

I can't build it for now, can you build it locally ?

custom-1                | LookupError: Entry point 'main' not found in egg 'custom' (protocols: paste.app_factory, paste.composite_factory, paste.composit_factory; entry_points: )

edit : RESOLVED

geoportal/vars.yaml Show resolved Hide resolved
ui/README.md Outdated Show resolved Hide resolved
ui/README.md Outdated Show resolved Hide resolved
ui/README.md Outdated Show resolved Hide resolved
ui/README.md Outdated Show resolved Hide resolved
ui/README.md Outdated Show resolved Hide resolved
ui/desktop.html Show resolved Hide resolved
ui/src/interfaces/ControllerDesktop.ts Outdated Show resolved Hide resolved
ui/vite.config.js Show resolved Hide resolved
ui/README.md Show resolved Hide resolved
@sbrunner
Copy link
Member Author

For me, the README.rst uses old syntax from c2cgeoportal scaffold, I don't know if we should change it, but it will affect all projects!

@ger-benjamin
Copy link
Member

Now, the dev server works and display the new ui.
But I've some errors in the console:

image

@sbrunner
Copy link
Member Author

I just fixed the Google error, but I didn't see the tooltip error, do you still have them?

@ger-benjamin
Copy link
Member

Google is effectively fixed.

Yes, it's at line like (in // node_modules/ngeo/distlib/srcapi/elements/ToolButtonElement.js):

  firstUpdated() {
    (0, import_jquery.default)(this.shadowRoot.querySelectorAll("[data-toggle='tooltip']")).tooltip();
  }

The element exists, but the tooltip "is not a function (unknown)

@sbrunner
Copy link
Member Author

It's strange because this:
https://github.com/camptocamp/demo_geomapfish/pull/1477/files#diff-1f6c1cb1f1a2966748b7e51455bf9a562ad54d3a6c7e75b638b8f6753b8ab2f5R518-R529
should add the tooltip method...
Do they be loaded correctly on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants