Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white select area in windows #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Marc-9
Copy link

@Marc-9 Marc-9 commented Jun 23, 2021

CLOSES #5, #82, #142

When running Excalibur in windows, selecting the area where the tables exist whether by your mouse or by autodetect tables shows a white box rather than the document behind it.
Looking at your terminal shows this is because of a 404 as the server can not find the image to show.
For some reason that I have not figured out on windows only, the image path gets mangled and some of the forward slashes are instead replaces with backslashes.

This resolves that issue.

@Marc-9
Copy link
Author

Marc-9 commented Jun 25, 2021

I realized that replacing the backslash problem on the server solved the issue for pdfs that were already uploaded but any new pdfs uploaded would not work.

By making the chance occur when the select area library tried to access it seems to fix the problem for previous uploads and future uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table area selection shows up as white instead of transparent on Windows
1 participant