Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement CogVideo model #969

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

mrsbeep
Copy link
Contributor

@mrsbeep mrsbeep commented Sep 17, 2024

Description

Add CogVideo model. Currently, to test this model, we need a server that runs this model and provides an endpoint.
Note: This is the drafe PR. I would like to receive more reviews to complete this.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #805

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Implement CogVideo model

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@mrsbeep mrsbeep linked an issue Sep 17, 2024 that may be closed by this pull request
2 tasks
"""
self.model_type = model_type
self.model_config_dict = model_config_dict
self._url = url or os.environ.get("COGVIDEO_API_BASE_URL")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that COGVIDEO_API_BASE_URL in env can never be read

Copy link
Collaborator

@koch3092 koch3092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrsbeep , there is a question for discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Text to video model
3 participants