Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support conditional tool calling #1141

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

ZackYule
Copy link
Collaborator

@ZackYule ZackYule commented Nov 1, 2024

Description

Builded a FSM with FunctionToolState and tools_space to support conditional tool calling.

Motivation and Context

close #951

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Complete the basic structure.
  • Creating a single agent demo.
  • Configuring the TaskManager through agents.
  • Replace with more appropriate variable names.

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

Wendong-Fan and others added 30 commits September 13, 2024 03:28
- Refactor toolkit imports in `camel/toolkits/__init__.py`
- Add `ToolManager` class to manage dynamically loading and accessing toolkits in `camel/toolkits/toolkits_manager.py`
@ZackYule ZackYule self-assigned this Nov 1, 2024
@ZackYule
Copy link
Collaborator Author

ZackYule commented Nov 1, 2024

Related to issue #951

@ZackYule
Copy link
Collaborator Author

ZackYule commented Nov 1, 2024

I think the root_task should be removed from the TaskManager, because according to its design, it can add tasks and sort them without setting all tasks as sub-tasks of a root_task. There is also no special handling for root_task. So I want to know if removing the root_task is appropriate, as it would make the code of support conditional tool calling more elegant. @yiyiyi0817 @zhiyu-01

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ZackYule , this PR need to be cleaned for further code review, how it includes some change from former commited PR, also could you fix the conflict with master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support conditional tool calling
4 participants