chore: fixing typing errors for pyright 1.1.373 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the really quick fixing of stuff, really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typing issues with the most recent merge, which seems to be related to the newest version of pyright. The
clserrors begin appearing in 1.1.372, and the error about theround()function is only in 1.1.373. I think the 1.1.373 issue is a bug in pyright, because it doesn't make any sense why this should be an error, and the error disappears if theround()is moved one line up. Alsoround()is called lots of other places in the file with similar arguments with no issues. Moving the line up doesn't change the logic at all and fixes typing, so... 🤷♂️.