fix(ios): keyboard auto dismisses #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
5 tasks
|
Thank you @andreialecu for the contribution 🎉 |
|
Hey @andreialecu thanks for your work on this. Just wanted to share a quick personal experience that your initial fix (with With I've got a lot of moving parts in my app and haven't had a chance to isolate it yet but just wanted to drop a comment in case it's relevant! |
|
Indeed I also noticed this just one time. Seems to still occur but very rarely in my experience. Looks like more investigation is needed. |
This was referenced Jun 27, 2022
chuece
added a commit
to chuece/react-native-pager-view
that referenced
this pull request
Sep 1, 2022
* Update ReactNativePageView.m * chore: add docs for attaching onPageScroll handler with reanimated (callstack#491) * add docs for attaching handler with reanimated * feat: add reanimated onpagescroll example * feat: add reanimated onpagescroll example * chore(docs): fix typos (callstack#497) * fix(ios): Crash when rapidly switching pages callstack#510 * Release 5.4.10 * chore(deps): bump nanoid from 3.1.22 to 3.2.0 in /example (callstack#506) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump trim-off-newlines from 1.0.1 to 1.0.3 (callstack#513) Bumps [trim-off-newlines](https://github.com/stevemao/trim-off-newlines) from 1.0.1 to 1.0.3. - [Release notes](https://github.com/stevemao/trim-off-newlines/releases) - [Commits](stevemao/trim-off-newlines@v1.0.1...v1.0.3) --- updated-dependencies: - dependency-name: trim-off-newlines dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump tmpl from 1.0.4 to 1.0.5 in /example (callstack#452) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump tmpl from 1.0.4 to 1.0.5 (callstack#451) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver-regex from 3.1.2 to 3.1.3 (callstack#449) Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(ios): wrong variable usage that causes crash related to callstack#458 (callstack#502) Introduced in callstack#455 this should have been `i` instead of `index` all along. * bump example * Release 5.4.11 * chore(deps): bump plist from 3.0.1 to 3.0.4 (callstack#525) Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.1 to 3.0.4. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump plist from 3.0.2 to 3.0.4 in /example (callstack#526) Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.2 to 3.0.4. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(ios): rapid taps on the navigation tabs (callstack#529) * bump example * Release 5.4.12 * fix(android): initialPage for dynamic content * Release 5.4.13 * Revert "fix(ios): rapid taps on the navigation tabs (callstack#529)" This reverts commit 27e8003. * fix(ios): switching between the pages for rapid tabs * Release 5.4.14 * fix(ios): crash with `NSInternalInconsistencyException` on iOS (callstack#530) * Release 5.4.15 * chore(docs): fix PagerView import (callstack#533) * chore: fix android example * chore: add native stack navigator * fix lint * chore: update pods * fix(ios): set delaysContentTouches to YES (callstack#563) * Release 5.4.16 * fix(ios): NSInternalInconsistencyException crash (callstack#564) Added additional checks to scroll without animation if already an animation is in progress to fix `NSInternalInconsistencyException` crash in iOS * Release 5.4.17 * fix(android): scrapped or attached views may not be recycled callstack#173 (callstack#552) * Release 5.4.18 * fix(ios): disable pager scroll gesture on swipe to go back (callstack#500) * fix: disable pager scroll gesture on swipe to go back * fix: navigation controller nil * Release 5.4.19 * fix(ios): pager sometimes does not fill full height (callstack#565) Fixes callstack#523 Fixes callstack#543 See callstack#518 (comment) for more info. * Release 5.4.21 * fix(android): only remove child if it exists (callstack#560) * Release 5.4.22 * fix(ios): keyboard auto dismisses (callstack#567) Fixes callstack#566 * Release 5.4.23 * fix(ios): restore animated param check (callstack#569) * chore: bump example * Release 5.4.24 * fix(ios): incorrect pager height (callstack#580) Co-authored-by: Andrei Alecu <[email protected]> * Release 5.4.25 * fix(android): assign an id to host view (callstack#585) (callstack#587) Co-authored-by: Nishan <[email protected]> Co-authored-by: Vojtech Novak <[email protected]> Co-authored-by: doug-lessen <[email protected]> Co-authored-by: Piotr Trocki <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Danilo Bürger <[email protected]> Co-authored-by: Jan-Rixt Van Hoye <[email protected]> Co-authored-by: Rishat Shamsutdinov <[email protected]> Co-authored-by: Numan <[email protected]> Co-authored-by: Hirbod <[email protected]> Co-authored-by: Rupesh Chaudhari <[email protected]> Co-authored-by: lxp <[email protected]> Co-authored-by: Andrei Alecu <[email protected]> Co-authored-by: Levi W <[email protected]> Co-authored-by: mateusz-ramski <[email protected]> Co-authored-by: Andrei Alecu <[email protected]> Co-authored-by: Luis Fernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #566
Related:
#462
satya164/react-native-tab-view#1244
Test Plan
See repro in #566 and video there.
After this change:
Simulator.Screen.Recording.-.iPhone.13.-.2022-05-23.at.17.11.25.mp4
What's required for testing (prerequisites)?
See repro in #566 and video there.
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md