Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving test coverage #91

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Improving test coverage #91

merged 4 commits into from
Sep 25, 2024

Conversation

shackett
Copy link
Collaborator

Description of your changes

  • While I was on a plane I added a bunch of tests to improve coverage.
  • This led me to two bugs
    • ordered variables were mishandled in coerce_to_classes
    • error in how classes were updated when clustering columns

Issue ticket number and link

Type of change

  • Bug fix
  • New feature
    • Backwards Incompatible?
  • Refactoring / code clean-up
  • Documentation add / update
  • Automated Test
  • Other (please specify)

(If applicable) How has this been tested?

@shackett shackett merged commit 791260b into main Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant