feat: apply full width automatically for DataTable #18357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
ui
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/23/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/02/25)1 label was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
eunjae-lee
force-pushed
the
feat/full-width-data-table
branch
6 times, most recently
from
7c6cee6 to
b3812fc
Compare
eunjae-lee
commented
Dec 24, 2024
| } | ||
| return colSizes; | ||
| }, [table.getFlatHeaders(), table.getState().columnSizingInfo, table.getState().columnSizing]); | ||
| const columnSizingVars = useColumnSizingVars({ table }); |
There was a problem hiding this comment.
extracted as a separate file for readability
| @@ -543,6 +542,11 @@ function UserListTableContent() { | |||
| } | |||
| }; | |||
|
|
|||
| if (!isSuccessAttributes) { | |||
There was a problem hiding this comment.
this is to avoid flickering (attributes are fetched at the similar timing as the table data, anyway)
eunjae-lee
force-pushed
the
feat/full-width-data-table
branch
from
5cd74fa to
8d0090e
Compare
dosubot
bot
added
the
🧹 Improvements
Udit-takkar
reviewed
Jan 1, 2025
Hey @Udit-takkar , that's a good point. Currently the member column is pinned. I'll think about how/when to disable pinning feature for small viewports, and apply the change here soon. update: fixed 10ea635 |
Udit-takkar
approved these changes
Jan 2, 2025
E2E results are ready! |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
* feat: apply full width automatically for DataTable * change implementation * load all columns of insights routing table at the same time * update team member list * sticky columns for >= sm * fix type error --------- Co-authored-by: Udit Takkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves DataTable to fill the full width.
Details
How we calculate the default width of columns in DataTable:
sizevalues as a part of ColumnDef. Example:cal.com/packages/features/users/components/UserTable/UserListTable.tsx
Line 203 in d71b9e2
getSize()function and its default value (https://tanstack.com/table/latest/docs/api/features/column-sizing#getsize)When browser's width is too large or there is not enough columns, the DataTable doesn't fill the full width. It used to do so, but not anymore since we've applied
flexto<TableRow />for the following reasons:This PR fixes the logic to calculate the column widths by increasing them a bit more if the calculated total widths doesn't fill the container's clientWidth. They are also re-calculated as browser resizes.
Screenshot.2024-12-24.at.16.55.12.mp4
New behaviors:
1. initially full width
2. still full width on browser resize (but will have horizontal scroll if browser width is too small)
3. it adjusts other columns' widths automatically when resizing a column
4. it saves only intentionally resized columns in localStorage
(The recalculation of column sizes on window resize is debounced for better performance.)
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
If you already have resized columns, it may affect the result. So it's better to delete data from localStorage before testing. Delete all the keys starting with
data-table-column-sizing-.DataTable should look good in the following pages:
Checklist