Avoid Memory Leaks [No ClickUp ticket] #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronardcaktus
changed the title
dchukhin
reviewed
Nov 1, 2023
Dockerfile
Outdated
| @@ -183,3 +183,6 @@ ENV PATH=/code/venv/bin:$PATH | |||
| WORKDIR /code | |||
|
|
|||
| CMD ["python", "/code/manage.py", "runserver", "0.0.0.0:8000"] | |||
|
|
|||
| # Reload workers after the specified amount of managed requests (avoid memory leaks) | |||
| ENV UWSGI_MAX_REQUESTS=1000 | |||
There was a problem hiding this comment.
Should we set this earlier on in the file, before we start uWSGI?
There was a problem hiding this comment.
Ah yes, I think it should be up by line 89
There was a problem hiding this comment.
I moved it up. Great suggestion @dchukhin. I moved it 🆙.
ronardcaktus
added a commit
that referenced
this pull request
Feb 14, 2024
Avoid Memory Leaks [No ClickUp ticket]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables reloading workers after a specified amount of managed requests -
1000- to avoid memory leaks.