Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate select (multiple choice) values. #4

Open
wants to merge 2 commits into
base: allowed_values_ui
Choose a base branch
from

Conversation

kmtracey
Copy link
Member

Extend the existing validity checking (had been added just for dates) to also include validing that select values match values provided for the property in the data dictionary. As with dates, do this if and only if the feature flag for data dictionary import validation is enabled.

Summary

Feature Flag

Product Description

Safety Assurance

  • Risk label is set correctly
  • All migrations are backwards compatible and won't block deploy
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • If QA is part of the safety story, the "Awaiting QA" label is used
  • I have confidence that this PR will not introduce a regression for the reasons below

Automated test coverage

QA Plan

Safety story

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Extend the existing validity checking (had been added just for dates) to also include validing that select values match values provided for the property in the data dictionary. As with dates, do this if and only if the feature flag for data dictionary import validation is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant