Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH4150/4197: Codegen styling & nullable param #4259

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

devlead
Copy link
Member

@devlead devlead commented Nov 16, 2023

Results in about 5k fewer lines of code generated.
Fixes issues with nullable return types and parameters.

@devlead devlead requested a review from a team November 17, 2023 14:48
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 enabled auto-merge November 18, 2023 16:50
* fixes cake-build#4150 - Fix styling warnings
* fixes cake-build#4197 - Fix parameter nullability error
@gep13 gep13 merged commit 829df67 into cake-build:develop Nov 18, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants