Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH4255: Introduce Verify for CodeGen Expectations #4256

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

devlead
Copy link
Member

@devlead devlead commented Nov 15, 2023

@SimonCropp
Copy link

u should tweak encoding and line endings in gitattributes and editor config

@SimonCropp
Copy link

if builds fail on CI it is nice to expose the recieved files for download https://github.com/VerifyTests/Verify/blob/main/docs/build-server.md

@SimonCropp
Copy link

Verify.DiffPlex help with the signal to noise. especially in CI https://github.com/VerifyTests/Verify.DiffPlex

@devlead
Copy link
Member Author

devlead commented Nov 16, 2023

if builds fail on CI it is nice to expose the recieved files for download https://github.com/VerifyTests/Verify/blob/main/docs/build-server.md

Sensible addition can add that in dotnet test Task OnError
https://cakebuild.net/docs/writing-builds/tasks/error-handling

I'll add an issue to track that post 4.0 release.

@devlead
Copy link
Member Author

devlead commented Nov 16, 2023

u should tweak encoding and line endings in gitattributes and editor config

added.

@devlead
Copy link
Member Author

devlead commented Nov 16, 2023

Verify.DiffPlex help with the signal to noise. especially in CI https://github.com/VerifyTests/Verify.DiffPlex

I'll add an issue to track that post 4.0 release.

@devlead devlead requested review from a team and removed request for a team November 16, 2023 12:42
Copy link
Member

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@devlead devlead merged commit dc378ed into cake-build:develop Nov 16, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Verify for CodeGen Expectations / Asserts
3 participants