-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeReuse property to DotNetMSBuildSettings #4194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Small change on the command-line
src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Cake.Common.Tests/Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs
Outdated
Show resolved
Hide resolved
54dba90
to
449eb23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@augustoproiete seems like this one somehow got stuck pending approval despite having approval? 🤔 |
449eb23
to
4ed7c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Marusyk your changes have been merged, thanks for your contribution 👍 |
Add NodeReuse property to DotNetMSBuildSettings and tests
Fixes #4144
Please review,
Thank you in advance