Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeReuse property to DotNetMSBuildSettings #4194

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

Marusyk
Copy link
Contributor

@Marusyk Marusyk commented Jul 16, 2023

Add NodeReuse property to DotNetMSBuildSettings and tests

Fixes #4144

Please review,
Thank you in advance

Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Small change on the command-line

Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexrp
Copy link

alexrp commented Aug 5, 2023

@augustoproiete seems like this one somehow got stuck pending approval despite having approval? 🤔

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@augustoproiete augustoproiete merged commit 4682b35 into cake-build:develop Sep 29, 2023
6 checks passed
@devlead
Copy link
Member

devlead commented Sep 29, 2023

@Marusyk your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DotNetMSBuildSettings is missing NodeReuse
4 participants