rewrite: Add option to force modifying the query #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for proposing this Francis, I'll try to get around to reviewing this soon. (Sorry for the delay. I'm also curious about this versus #5504) |
mholt
reviewed
Sep 26, 2024
| // only the path would be rewritten because the placeholder itself | ||
| // does not contain a '?' character. Only use this if the placeholder | ||
| // is trusted to not be vulnerable to query injections. | ||
| ModifyQuery bool `json:"modify_query,omitempty"` |
There was a problem hiding this comment.
What if we call this SpanComponents or something a little more precise? It looks like what this change really does is make a single placeholder able to span URI components.
There was a problem hiding this comment.
That makes me think of a <span> JS component. That name doesn't bring any mental association to what it does to me.
There was a problem hiding this comment.
Hmm. I mean, obviously this is a backend context (a rewrite middleware) where we're talking about the URI... but I can see why you'd have that correlation.
What about AllowExpansion or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5208
When a user wants to rewrite the URI, if they use a placeholder which might contain both the path and query, currently only the path portion of the placeholder will be used and the query is discarded.
This isn't ideal when the placeholder input comes from, for example, a response header from upstream when doing
X-Accel-Redirectstyle intercepting of the response.To work around this, we can add an option to force-enable query modifications, essentially marking the configured placeholder input as "trusted" in the sense that it's expected to contain a valid query part and not an injected
?via URL encoding.I'm not sure the implementation is completely correct. There's a test case I'm not quite sure how we want to handle, i.e. the placeholder only having a query and no path. Is that something we care to support? If not I can remove that
TODOcomment.