Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study view: fix comparison session generation from study view bin cha… #4767

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented Nov 2, 2023

Charts in study view sometimes have bins which are single integers. In this case, the "bins" are represtend as having the same start and end value. In this case, to fall into this bin, the values must equal the start/end

@alisman alisman force-pushed the fxComparisonSessionGenerat branch from 805f4de to f73a4e0 Compare November 6, 2023 22:38
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree it's ok to add this special case to our codebase.

@dippindots dippindots added the bug label Nov 7, 2023
@alisman alisman merged commit bfd177b into cBioPortal:master Nov 7, 2023
4 of 5 checks passed
@alisman alisman deleted the fxComparisonSessionGenerat branch November 7, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants