Experiment with clinical data table filtering #4667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
force-pushed
the
clindata_filter
branch
2 times, most recently
from
bfdeb22 to
38be36e
Compare
BasLee
reviewed
Jul 27, 2023
| this.clinicalDataSortCriteria?.field | ||
| } | ||
| downloadDataFetcher={() => | ||
| Promise.resolve(['moo']) |
BasLee
reviewed
Jul 27, 2023
| @@ -34,11 +37,18 @@ class ClinicalDataTabTableComponent extends LazyMobXTable<{ | |||
| [id: string]: string; | |||
| }> {} | |||
|
|
|||
| const CLINICAL_DATA_RECORD_LIMIT = 500; | |||
BasLee
reviewed
Jul 27, 2023
| downloadDataFetcher?: | ||
| | ILazyMobXTableApplicationLazyDownloadDataFetcher | ||
| | (() => Promise<any>) | ||
| | undefined; |
There was a problem hiding this comment.
can already be undefined because it is optional, I think?
BasLee
reviewed
Jul 27, 2023
| @@ -923,7 +958,9 @@ export default class LazyMobXTable<T> extends React.Component< | |||
| this.handlers = { | |||
| onFilterTextChange: (() => { | |||
| return inputBoxChangeTimeoutEvent(filterValue => { | |||
| this.store.setFilterString(filterValue); | |||
| props.onFilterTextChange | |||
There was a problem hiding this comment.
What is the difference between these two? Maybe add a comment
pvannierop
force-pushed
the
clindata_filter
branch
from
994893a to
274d33a
Compare
alisman
force-pushed
the
clindata_filter
branch
from
281b2fc to
86104e4
Compare
pvannierop
force-pushed
the
clindata_filter
branch
from
86104e4 to
2a9e8b2
Compare
alisman
force-pushed
the
clindata_filter
branch
from
7a8ebe6 to
f02cfb9
Compare
Instead of display name.
alisman
force-pushed
the
clindata_filter
branch
from
f02cfb9 to
bf452d7
Compare
…pulated to avoid flash of two column table (premature)
pvannierop
force-pushed
the
clindata_filter
branch
from
6ff3c01 to
b6a59d2
Compare
alisman
force-pushed
the
clindata_filter
branch
from
b6a59d2 to
6ff3c01
Compare
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new paginated endpoint for clinical data search/download tab. This pull request adapts MobxLazyTable for use with new pagination service. Rather than enable traditional pagination, it enables sorting and filtering with a limit on the number of records that the viewer can fetch.
Fixes cBioPortal/cbioportal#10479