Issue 1527 kma20 #1531
Open
Issue 1527 kma20 #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the handbook, the MIC selector knob also can switch the audible COM radio, when the AUTO switch is active and the switch for the radio is in OFF position. As I interpret this, setting a radio to SPKR or HEADPHONE will make that radio alwas audible (so its an override for the AUTO switch). Also, the code now does calculate the "operable" property to make it failable by setting "serviceable" to false. The panel has a failsafe mode: when the panel fails, COM1 is hardwired to the speaker/headset and mic. see c172p-team#1527
When activated via aircraft-options menu: - Space and shift-space keybinds will use the radio selected by the panels MIC knob. - The transmission will only activate, when panel and the selected COM is operable. - If the KMA20 panel fails, mic is wired to COM1 (falsafe mode). - When PTT is activated, the respective radio gets muted (radios are half-duplex).
|
I'll take a look soon and get this merged. Thanks! |
|
Thank you. One thing that came to my mind this night: |
|
put on hold, I want to add some things. |
|
OK, Wayne, you can have a look now. |
Thi should give unmeasurable better performance, but peace for the soul.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested OK, should be fine to merge
Fix #1527