Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add condition over os_type to preproc #417

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FardaleM
Copy link
Collaborator

I started working on CCFilename, a lot of function depend on OS specific definition. Therefore I add the possibility to match the os_type using the preprocessor.

@c-cube
Copy link
Owner

c-cube commented Sep 18, 2022

Seems like a good idea! Have you tested it already? :)

@FardaleM FardaleM marked this pull request as draft September 19, 2022 10:13
@FardaleM
Copy link
Collaborator Author

I just tried it and it currently does not work. The fix is small but I want to improve a bit more stuff as I work with it. So I will keep it as a draft for now except if you want to have it merge early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants