-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/show openai error message #113
Merged
ryo-ma
merged 10 commits into
c-3lab:main
from
minheibis:feature/show-openai-error-message
Aug 18, 2023
Merged
Feature/show openai error message #113
ryo-ma
merged 10 commits into
c-3lab:main
from
minheibis:feature/show-openai-error-message
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1392 1429 +37
Branches 146 147 +1
=========================================
+ Hits 1392 1429 +37
|
エラーの場合、以下のように表示されます
|
ryo-ma
reviewed
Aug 14, 2023
ryo-ma
reviewed
Aug 14, 2023
@minheibis ありがとうございます。大方問題なさそうです。少し細かい点で指摘させていただきましたのでご確認ください。 |
@ryo-ma ご確認ありがとうございます、エラーメッセージの説明について、大文字から始まるように修正しました。 |
@minheibis ありがとうございます。問題なさそうなのでマージしていきます。 |
早速マージありがとうございます! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #112 への対応
libs/openai_client.ts
実装自体はこちらの変更で、openai のエラーの際のレスポンスを表示するようにしています。
tests/libs/actions.generate.test.ts
に"handles error when OpenAI API returns an error"というテストを追加したのですが、テストの書き方がこれで良かったのかわからないので、見ていただけるとありがたいです。