Enable non-standard OpenBLAS extensions #1571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduce openblas_full, as an alternative to openblas, and load the extra functions there.
openblas_full is an alternative to openblas that doesn't skip any function provided by openblas, except deprecated functions. It includes functions that are not present in Accelerate and/or MKL, but are included in OpenBLAS as an useful addition to the netlib BLAS interface.
... and just redefines map().
saudet
reviewed
Jan 22, 2025
openblas/src/main/java/org/bytedeco/openblas/presets/openblas_full.java
Outdated
Show resolved
Hide resolved
saudet
reviewed
Jan 22, 2025
openblas/src/main/java/org/bytedeco/openblas/presets/openblas_full.java
Outdated
Show resolved
Hide resolved
saudet
reviewed
Jan 22, 2025
| * @author Dragan Djuric | ||
| */ | ||
| @Properties(inherit = openblas.class, global = "org.bytedeco.openblas.global.openblas_full", value = { | ||
| @Platform(include = {"openblas_config.h", "cblas.h", "lapacke_config.h", "lapacke_mangling.h", "lapack.h", "lapacke.h", "lapacke_utils.h"})}) |
There was a problem hiding this comment.
If the include list is the same as openblas.class, we probably don't need to add it here. Can you try to remove this line?
There was a problem hiding this comment.
Yes, of course. Sorry for these sloppy edits, I'm doing this through GitHub editor :) Update's comming in a minute.
There was a problem hiding this comment.
Sorry, I misread that you mean about java imports. I'll be back in a minute :)
There was a problem hiding this comment.
Yes, yes, I know... Sorry. I hope the next edit will be ok :)
There was a problem hiding this comment.
Maybe the previous actions should be cancelled before they finish...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution enables the operations that are present in OpenBLAS, but might not be directly supported by Accelerate and/or MKL. The previous behavior is preserved, and the new openblas_full class added, which extends the openblas class and enables the "extra" operations.