Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cuda build for librealsense2 #1032

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

n-kai-cj
Copy link
Contributor

Add cuda build option BUILD_WITH_CUDA for librealsense2.
We can get benefits of cuda for some processes such as alignment.

@saudet
Copy link
Member

saudet commented Apr 17, 2021

CUDA is only available for linux-arm64, linux-ppc64le, linux-x86_64, and windows-x86_64, but it won't work with linux-arm64 and linux-ppc64le because we would need first to get the cross-compiler working on GitHub Actions, so please adjust the workflows/librealsense2.yml and platform/gpu/pom.xml files with only linux-x86_64 and windows-x86_64, for now anyway. Thanks!

@n-kai-cj
Copy link
Contributor Author

I modified to add CUDA option for only linux-x86_64 and windows-x86_64.

BTW, CUDA option is originally for ARM platform because librealsense2 supports only SSE and CUDA backend, NEON is not implemented.
I'd like to use linux-arm64-gpu, could you make environments with cross-compiler for ARM? or are there anything I could help?

@saudet
Copy link
Member

saudet commented Apr 17, 2021 via email

@n-kai-cj
Copy link
Contributor Author

Actually I don't understand GitHub Actions at all, but I'll try to learn.

@saudet
Copy link
Member

saudet commented Apr 17, 2021 via email

@n-kai-cj
Copy link
Contributor Author

I did build success on pure arm platform with CUDA, but I'm not sure whether we can build CUDA with cross compiling.
GitHub Actions may have ARM actions function? If yes, we don't need to cross compile.
https://github.com/marketplace/actions/arm-action

@saudet
Copy link
Member

saudet commented Apr 17, 2021 via email

@n-kai-cj
Copy link
Contributor Author

I found CUDA is not supported by ARM except for Jetson. So I removed ARM build from GitHub Actions workflow, but cuda build option is left so that we can get linux-arm64-gpu.jar if we build with physical arm platform such as Jetson.

@saudet
Copy link
Member

saudet commented Apr 17, 2021

@saudet
Copy link
Member

saudet commented Apr 19, 2021

In any case, please fix the workflow and let's see if there are any build errors. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants