fix: no_std fix use without unwind
#9977
Open
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
bjorn3
reviewed
Jan 10, 2025
| let caller_sp_to_cfa_offset = | ||
| crate::isa::unwind::systemv::caller_sp_to_cfa_offset(); | ||
| #[cfg(not(feature = "unwind"))] | ||
| let caller_sp_to_cfa_offset = 0; // TODO is this right? |
There was a problem hiding this comment.
Maybe compute_value_labels_ranges should be made to return ValueLabelsRanges::default(); when the unwind feature is disabled? Except for values which just so happen to be in registers, I don't think it is possible to generate valid debuginfo for locals when the unwind table is not also emitted.
There was a problem hiding this comment.
Arguably, the register values are just as 'meaningless' in the no-unwind case as you need the unwind info to recover them (unless you are willing to disassemble code to guide your unwinder). Ultimately, the debug info production 'feature' is tightly coupled to the unwinding feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of no_std support in cranelift this PR fixes uses of the
isa/unwindmodule throughcraneliftso thatcraneliftcan be compiled with theunwindfeature (which depends onstdlibthroughgimli) disabled.